-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drain state implementation #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10493988690Details
💛 - Coveralls |
adrianchiris
commented
Aug 21, 2024
Define Interfaces and provide implementations for draining. Two Interfaces defined: 1. DrainRequest interface represents a single drain request, it provides start/stop/status of the request eventually driving drain kubectl API 2. Manager interface manages DrainRequests Signed-off-by: adrianc <[email protected]>
Signed-off-by: adrianc <[email protected]>
implement handling of drain state. - add handler function for drain state - use drain manager to handle drain requests - handle NodeMaintenance updates/deletion during drain - extend controller test to cover draining state Signed-off-by: adrianc <[email protected]>
adrianchiris
force-pushed
the
add-drain
branch
from
August 21, 2024 16:45
f527ef8
to
b69752a
Compare
ykulazhenkov
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to individual commits for context.